[tex-live] Patch to make gui installer usable from keyboard

Alexander Cherepanov cherepan at mccme.ru
Sun Oct 11 11:59:03 CEST 2009


Hi Norbert!
On Sun, 11 Oct 2009 07:06:44 +0200, Norbert Preining <preining at logic.at> wrote:

> Thanks a lot, nice patch. I have committed it with one small fix.

Thanks.

>> --- installer.orig/install-menu-perltk.pl	2009-10-10 15:55:28.750000000 +0400
>> +++ installer/install-menu-perltk.pl	2009-10-10 22:11:37.531250000 +0400
>> @@ -367,7 +367,7 @@
>>    my $b = $f->Button(-text => __("Cancel"),
>>                       -command => sub { $::sww->destroy; $mainwindow->destroy;
>>                                         do_cleanup(); exit(1); }
>> -                    )->pack(-pady => "2m");
>> +                    )->pack(-pady => "2m")->focus();

> That was not a good idea, since at the end we call
> 	$b->configure(...)
> to change the text to "Finished", and with that $b is undefined (the return
> value of focus()!)

Well, it's the result of last minute optimization:-(

>> Tested on Windows only.

> Did the final button *actually* change from "Cancel" to "Finish" and there
> has not been any warning on the cmd line with the perltk installer? I would
> be surprised.

It was trumped by other error message -- when installing only wintools 
installer dies not founding texmf.cnf. I've left it to sort it out 
tomorrow (i.e. today). So should it be possible to install only 
wintools?:-)

> Anyway, with my fix (adding above a $b->focus(); instaead of attaching the
> ->focus()) it works now.

Cool!

Alexander Cherepanov




More information about the tex-live mailing list